[PATCH] D17857: [ELF] - DT_TEXTREL/DF_TEXTREL flags implemented.

Joerg Sonnenberger via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 3 13:42:04 PST 2016


On Thu, Mar 03, 2016 at 06:54:51PM +0000, Davide Italiano via llvm-commits wrote:
> Comment at: ELF/OutputSections.cpp:621
> @@ +620,3 @@
> +  if (Out<ELFT>::RelaDyn->TextRel) {
> +    Add({DT_TEXTREL, (uint64_t)0});
> +    DtFlags |= DF_TEXTREL;
> ----------------
> So, DT_TEXTREL tag is not needed. It's for compatibility with older
> loaders, which is unlikely we're going to support anyway. I'd like to
> keep it away until somebody asks for it.

We check only for DT_TEXTREL in NetBSD. When did people decide that
everything needs to exist in a hundred random forms just for the sake of
duplicating functionality?

Joerg


More information about the llvm-commits mailing list