[PATCH] D17600: Disabling CTR loops optimization for soft float operations

[Hal Finkel via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

A few minor comments, otherwise, LGTM.


================
Comment at: lib/Target/PowerPC/PPCCTRLoops.cpp:425
@@ -424,1 +424,3 @@
     }
+    if (TM->getSubtargetImpl(*BB->getParent())->getTargetLowering()->useSoftFloat()) {
+      switch(J->getOpcode()) {
----------------
Please add blank lines before and after this if statement to visually separate it from the surrounding checks.

================
Comment at: test/CodeGen/PowerPC/ctrloops-softfloat.ll:137
@@ +136,3 @@
+
+!0 = !{!"clang version 3.8.0 (trunk 256152) (llvm/trunk 256144)"}
+!1 = !{!2, !2, i64 0}
----------------
Please remove unnecessary metadata (looks like none of it is necessary)


Repository:
  rL LLVM

http://reviews.llvm.org/D17600