[PATCH] D15390: [ThinLTO] Launch importing backends in parallel threads from gold plugin

[Peter Collingbourne via llvm-commits]

pcc accepted this revision.
pcc added a comment.
This revision is now accepted and ready to land.

LGTM


================
Comment at: tools/gold/gold-plugin.cpp:985-988
@@ -809,2 +984,6 @@
 
-  std::vector<SmallString<128>> Filenames(options::Parallelism);
+  // TODO: Should this use thread::hardware_concurrency() if
+  // -jobs option was not specified? Currently preserve behavior of
+  // default parallelism being 1.
+  unsigned int MaxThreads = options::Parallelism ? options::Parallelism : 1;
+
----------------
I don't think this should be dependent on a property of the host machine, as there are behavioral differences between parallelism levels (e.g. symbol ordering will be different, and some uses of inline asm won't work with parallelism >1, although some of that is arguably a bug). Can you please update the comment to reflect that?


http://reviews.llvm.org/D15390