[PATCH] D17270: Support arbitrary addrspace pointers in masked load/store intrinsics

Artur Pilipenko via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 3 07:53:58 PST 2016


apilipenko added inline comments.

================
Comment at: lib/IR/IRBuilder.cpp:216
@@ -215,5 +215,3 @@
   assert(Ptr->getType()->isPointerTy() && "Ptr must be of pointer type");
-  // DataTy is the overloaded type
-  Type *DataTy = cast<PointerType>(Ptr->getType())->getElementType();
-  assert(DataTy->isVectorTy() && "Ptr should point to a vector");
+  PointerType *PtrTy = cast<PointerType>(Ptr->getType());
   if (!PassThru)
----------------
That seems like a good idea, but I'd like to keep the patch as simple as possible, namely I don't want to change IRBuilder API in this change. 


http://reviews.llvm.org/D17270





More information about the llvm-commits mailing list