[PATCH] D17851: [DebugInfo] The last byte of the entity is still a part of it.

Filipe Cabecinhas via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 3 07:29:43 PST 2016


filcab created this revision.
filcab added a reviewer: samsonov.
filcab added a subscriber: llvm-commits.

http://reviews.llvm.org/D17851

Files:
  lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
  test/DebugInfo/llvm-symbolizer.test

Index: test/DebugInfo/llvm-symbolizer.test
===================================================================
--- test/DebugInfo/llvm-symbolizer.test
+++ test/DebugInfo/llvm-symbolizer.test
@@ -3,6 +3,7 @@
 RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x400436" >> %t.input
 RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x400528" >> %t.input
 RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x400586" >> %t.input
+RUN: echo "%p/Inputs/dwarfdump-test.elf-x86-64 0x400564" >> %t.input
 RUN: echo "%p/Inputs/dwarfdump-test2.elf-x86-64 0x4004e8" >> %t.input
 RUN: echo "%p/Inputs/dwarfdump-test2.elf-x86-64 0x4004f4" >> %t.input
 RUN: echo "%p/Inputs/dwarfdump-test4.elf-x86-64 0x62c" >> %t.input
@@ -41,6 +42,8 @@
 CHECK: DummyClass
 CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test.cc:4
 
+CHECK:       main
+
 CHECK: a
 CHECK-NEXT: /tmp/dbginfo{{[/\\]}}dwarfdump-test2-helper.cc:2
 
Index: lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
===================================================================
--- lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
+++ lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp
@@ -179,7 +179,7 @@
     return false;
   --SymbolIterator;
   if (SymbolIterator->first.Size != 0 &&
-      SymbolIterator->first.Addr + SymbolIterator->first.Size <= Address)
+      SymbolIterator->first.Addr + SymbolIterator->first.Size < Address)
     return false;
   Name = SymbolIterator->second.str();
   Addr = SymbolIterator->first.Addr;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17851.49738.patch
Type: text/x-patch
Size: 1469 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160303/45105ed9/attachment.bin>


More information about the llvm-commits mailing list