[PATCH] D17831: [PGO] Add API to merge profile from buffer

Sean Silva via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 2 15:39:19 PST 2016


silvas added a comment.

Hi David, this looks really nice. You were right that the profraw merging is quite simple.

Can you update instrprof-without-libc.c test to include __llvm_profile_merge_from_buffer?

Also, would it be reasonable to omit the value prof merging until we can test it? If not, that's fine, but it may simplify this patch.


================
Comment at: test/profile/instrprof-merge.c:94
@@ +93,3 @@
+
+// Note profiled
+// CHECK-LABEL:  main:
----------------
Nit: Note -> Not


http://reviews.llvm.org/D17831





More information about the llvm-commits mailing list