[PATCH] D17781: Codegen: [PPC] Word Rotates are Zero Extending

[Eric Christopher via llvm-commits]

echristo added a comment.

One nit from me, but given I missed one thing previously I'm going to ask Hal to ack this one :)

-eric


================
Comment at: lib/Target/PowerPC/PPCInstrInfo.cpp:1557-1561
@@ -1556,2 +1556,7 @@
 
+  // 32-bit rotate and mask instructions are zero extending only if MB <= ME
+  bool isZeroExtendingRotate  =
+      (MIOpC == PPC::RLWINM || MIOpC == PPC::RLWINM)
+      && MI->getOperand(3).getImm() <= MI->getOperand(4).getImm();
+
   bool equalityOnly = false;
----------------
Stylistic request: Can you move this closer to the use please?


http://reviews.llvm.org/D17781