[PATCH] D17338: [SplitModule] Do not copy stale debug info during module splitting.

[Teresa Johnson via llvm-commits]

tejohnson added a comment.

In http://reviews.llvm.org/D17338#365399, @joker.eph wrote:

> Sorry for the delay, I'm not a debug info expert, so I won't be able to catch all corner cases, maybe D.Blakie or A.Prantl can help?
>  On the approach itself, it seems like a band-aid compared to filtering out what should be imported in the first place. Maybe Teresa who worked on the filtering has some input (or better: some refactored code to share?).


I agree with Mehdi that it would be ideal to fix this in CloneModule itself. And perhaps it can leverage the changes I have in http://reviews.llvm.org/D16440 which additionally avoids bringing in unnecessary composite types. Looks like it would be fairly natural as they both use a ValueMap and so the identification of what is needed by the mapped in functions should be the same. The support in my patch would need to be moved out to a common place though.

To get CloneModule to do the right thing with regards to subprogram metadata like you are doing here, AFAICT it will need to fix the way it is currently mapping subprograms (see the comment I just left on http://reviews.llvm.org/D17165).


http://reviews.llvm.org/D17338