[PATCH] D17803: ELF: Remove non-standard ELF features from AMDGPU target

[Rafael Ávila de Espíndola via llvm-commits]

rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with nits.

Thanks a lot!


================
Comment at: test/ELF/amdgpu-globals.s:123
@@ -122,3 +117,2 @@
 # CHECK: Name: program_global_readonly
-# CHECK: Value: 0x4
 # CHECK: Size: 4
----------------
Please leave just


```
# CHECK: Value:
``` 

The test should at some point be changed to use CHECK-NEXT.

================
Comment at: test/ELF/amdgpu-globals.s:136
@@ -135,3 @@
-# CHECK: ProgramHeader {
-# CHECK: Type: PT_AMDGPU_HSA_LOAD_CODE_AGENT
-# CHECK: VirtualAddress: [[HSATEXT_ADDR]]
----------------
Don't you want to convert this to "CHECK: Type: PT_LOAD"?

================
Comment at: test/ELF/amdgpu-kernels.s:53
@@ -52,3 +51,2 @@
 # CHECK: Name: kernel1
-# CHECK: Value: 0x100
 # CHECK: Size: 8
----------------
leave the "CHECK: Value:"


http://reviews.llvm.org/D17803