[llvm] r262428 - [CMake] Add convenience target llvm-test-depends to build test dependencies.

[ChrisBieneman via llvm-commits]

I took a quick look into this. It would be really difficult to do. That isn't to say we shouldn't do it, just that it will be quite a bit of work, and I can't commit to it at this time.

The problem is most of the lit suite targets are added through a call to "add_lit_testsuites" from AddLLVM.cmake. That function basically just searches for test suite cfg files, and adds targets. Because it is an automated glob we don't actually have fine grained dependency information for each suite.

I think we can build a mechanism for getting that information, but we don't have it today.

-Chris

> On Mar 1, 2016, at 9:08 PM, Chris Bieneman via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> I can look into this. The problem is the lit suites don't each call out their dependencies in CMake today, so I'm not sure how easy that will be to add.
> 
> -Chris
> 
>> On Mar 1, 2016, at 5:41 PM, NAKAMURA Takumi <geek4civic at gmail.com> wrote:
>> 
>> Could we enhance and generalize it in add_lit_testsuite with the target like "check-*-dependent"?
>> In past, we had phony targets like "check-*.deps" and I used them.
>> 
>>> On Wed, Mar 2, 2016 at 10:35 AM Sean Silva via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>>> On Tue, Mar 1, 2016 at 4:27 PM, Chris Bieneman via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>>>> Author: cbieneman
>>>> Date: Tue Mar  1 18:27:14 2016
>>>> New Revision: 262428
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=262428&view=rev
>>>> Log:
>>>> [CMake] Add convenience target llvm-test-depends to build test dependencies.
>>> 
>>> Yes! I've been wanting this!
>>>  
>>>> 
>>>> This is useful when paired with the distribution targets to build prerequisites for running tests.
>>>> 
>>>> Modified:
>>>>     llvm/trunk/test/CMakeLists.txt
>>>> 
>>>> Modified: llvm/trunk/test/CMakeLists.txt
>>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CMakeLists.txt?rev=262428&r1=262427&r2=262428&view=diff
>>>> ==============================================================================
>>>> --- llvm/trunk/test/CMakeLists.txt (original)
>>>> +++ llvm/trunk/test/CMakeLists.txt Tue Mar  1 18:27:14 2016
>>>> @@ -113,6 +113,8 @@ if(LLVM_BUILD_EXAMPLES)
>>>>      )
>>>>  endif()
>>>> 
>>>> +add_custom_target(llvm-test-depends DEPENDS ${LLVM_TEST_DEPENDS})
>>>> +
>>>>  add_lit_testsuite(check-llvm "Running the LLVM regression tests"
>>>>    ${CMAKE_CURRENT_BINARY_DIR}
>>>>    PARAMS llvm_site_config=${CMAKE_CURRENT_BINARY_DIR}/lit.site.cfg
>>>> 
>>>> 
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at lists.llvm.org
>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160302/ee8b59ef/attachment.html>