[PATCH] D17789: [cmake] Check the compiler version first

Chris Bieneman via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 2 08:39:43 PST 2016


beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

LGTM. One comment below to be addressed before commit.


================
Comment at: cmake/modules/CheckCompilerVersion.cmake:2
@@ +1,3 @@
+# Check if the host compiler is new enough. LLVM requires at least GCC 4.7,
+# MSVC 2013, or Clang 3.2.
+
----------------
The comment here says clang 3.2, but below you check for 3.1. We should make that consistent.


http://reviews.llvm.org/D17789





More information about the llvm-commits mailing list