[llvm] r262454 - Add a comment with a rational for the unusual code structure

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 1 18:56:30 PST 2016


Author: sanjoy
Date: Tue Mar  1 20:56:29 2016
New Revision: 262454

URL: http://llvm.org/viewvc/llvm-project?rev=262454&view=rev
Log:
Add a comment with a rational for the unusual code structure

Modified:
    llvm/trunk/lib/Analysis/ScalarEvolution.cpp

Modified: llvm/trunk/lib/Analysis/ScalarEvolution.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ScalarEvolution.cpp?rev=262454&r1=262453&r2=262454&view=diff
==============================================================================
--- llvm/trunk/lib/Analysis/ScalarEvolution.cpp (original)
+++ llvm/trunk/lib/Analysis/ScalarEvolution.cpp Tue Mar  1 20:56:29 2016
@@ -4577,6 +4577,9 @@ ConstantRange ScalarEvolution::getRangeV
   // from deep in the call stack, and calling getSCEV (on a sext instruction,
   // say) can end up caching a suboptimal value.
 
+  // FIXME: without the explicit `this` receiver below, MSVC errors out with
+  // C2352 and C2512 (otherwise it isn't needed).
+
   const SCEV *TrueStart = this->getConstant(*StartPattern.TrueValue + Offset);
   const SCEV *TrueStep = this->getConstant(*StepPattern.TrueValue);
   const SCEV *FalseStart = this->getConstant(*StartPattern.FalseValue + Offset);




More information about the llvm-commits mailing list