[llvm] r262388 - Revert "[AArch64] Fix isLegalAddImmediate() to return true for valid negative values."

Geoff Berry via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 1 13:15:27 PST 2016


Good point.  I believe the same is true for isLegalICmpImmediate() in the original code (and current top-of-tree after my revert).  I'll fix it before I re-commit this change.

--
Geoff Berry
Employee of Qualcomm Innovation Center, Inc.
 Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project


-----Original Message-----
From: Tim Northover [mailto:t.p.northover at gmail.com] 
Sent: Tuesday, March 01, 2016 3:57 PM
To: Geoff Berry
Cc: LLVM Commits
Subject: Re: [llvm] r262388 - Revert "[AArch64] Fix isLegalAddImmediate() to return true for valid negative values."

>     Revert r262248 in an attempt to fix the clang-native-aarch64-full 
> bot

Looks like it's probably got UB for INT64_MIN, though I obviously don't know if that's actually what's causing the issue.

Tim.



More information about the llvm-commits mailing list