[PATCH] D17758: [ELF] - handle of command line options incompatible with -r

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/Driver.cpp:144
@@ -143,3 +143,3 @@
 
-  if (Config->Relocatable && Config->Shared)
-    error("-r and -shared may not be used together");
+  if (Config->Relocatable) {
+    if (Config->Shared)
----------------
ruiu wrote:
> I'd use early return here.
> 
>   if (Config->Relocatable)
>     return;
>   if (Config->Shared)
>     ....
Done.

================
Comment at: test/ELF/relocatable-errors.s:1-2
@@ +1,3 @@
+# REQUIRES: x86
+# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1.o
+
----------------
ruiu wrote:
> Please add this to driver.test instead of to a new file.
Done.


Repository:
  rL LLVM

http://reviews.llvm.org/D17758