[PATCH] D17293: [MC] AsmLexer: 30% speedup on tests, added extensible identifier's character set support.

[Rafael Ávila de Espíndola via llvm-commits]

rafael added a subscriber: rafael.

================
Comment at: include/llvm/MC/MCParser/MCAsmLexer.h:211
@@ +210,3 @@
+  /// allow/disallow an identifier to contain specified characters
+  virtual void setIdentifierCharSet(bool Value,
+                                    StringRef PfxCharSet,
----------------
Why do you need to make these virtual?

================
Comment at: include/llvm/MC/MCParser/MCAsmLexer.h:216
@@ +215,3 @@
+  /// test whether the specified character can be found in an identifier
+  virtual bool isIdentifierCharSetContains(char) const = 0;
+
----------------
is..Contains is a strange name since it has two verbs.

================
Comment at: lib/MC/MCParser/AsmLexer.cpp:23
@@ -23,1 +22,3 @@
 
+// standard is(x)digit generally much slower than simple
+// checks like below
----------------
Why?


Repository:
  rL LLVM

http://reviews.llvm.org/D17293