[compiler-rt] r262283 - [asan] Retry failed adb commands in android tests.

[Evgeniy Stepanov via llvm-commits]

Author: eugenis
Date: Mon Feb 29 19:16:03 2016
New Revision: 262283

URL: http://llvm.org/viewvc/llvm-project?rev=262283&view=rev
Log:
[asan] Retry failed adb commands in android tests.

Add limited retries for push/pull adb commands in android tests.
May help with the adb flakiness.

Modified:
    compiler-rt/trunk/test/asan/android_commands/android_common.py

Modified: compiler-rt/trunk/test/asan/android_commands/android_common.py
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/test/asan/android_commands/android_common.py?rev=262283&r1=262282&r2=262283&view=diff
==============================================================================
--- compiler-rt/trunk/test/asan/android_commands/android_common.py (original)
+++ compiler-rt/trunk/test/asan/android_commands/android_common.py Mon Feb 29 19:16:03 2016
@@ -8,25 +8,30 @@ verbose = False
 if os.environ.get('ANDROID_RUN_VERBOSE') == '1':
     verbose = True
 
-def adb(args):
+def adb(args, attempts = 1):
     if verbose:
         print args
     tmpname = tempfile.mktemp()
     out = open(tmpname, 'w')
-    ret = subprocess.call([ADB] + args, stdout=out, stderr=subprocess.STDOUT)
+    ret = 255
+    while attempts > 0 and ret != 0:
+      attempts -= 1
+      ret = subprocess.call([ADB] + args, stdout=out, stderr=subprocess.STDOUT)
+      if attempts != 0:
+        ret = 5
     if ret != 0:
-        print "adb command failed", args
-        print tmpname
-        out.close()
-        out = open(tmpname, 'r')
-        print out.read()
+      print "adb command failed", args
+      print tmpname
+      out.close()
+      out = open(tmpname, 'r')
+      print out.read()
     out.close()
     os.unlink(tmpname)
     return ret
 
 def pull_from_device(path):
     tmp = tempfile.mktemp()
-    adb(['pull', path, tmp])
+    adb(['pull', path, tmp], 5)
     text = open(tmp, 'r').read()
     os.unlink(tmp)
     return text
@@ -35,5 +40,5 @@ def push_to_device(path):
     # Workaround for https://code.google.com/p/android/issues/detail?id=65857
     dst_path = os.path.join(ANDROID_TMPDIR, os.path.basename(path))
     tmp_path = dst_path + '.push'
-    adb(['push', path, tmp_path])
-    adb(['shell', 'cp "%s" "%s" 2>&1' % (tmp_path, dst_path)])
+    adb(['push', path, tmp_path], 5)
+    adb(['shell', 'cp "%s" "%s" 2>&1' % (tmp_path, dst_path)], 5)