[PATCH] D17679: [X86] Elide references to _chkstk for dynamic allocas

[Hans Wennborg via llvm-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

Nice! lgtm


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:16377
@@ +16376,3 @@
+            .getAsInteger(0, StackProbeSize);
+      // Dynamic allocas force a frame pointer, take that into account.
+      unsigned AlignedAlloc = SizeC->getZExtValue() + RegInfo->getSlotSize();
----------------
Can we check whether the alloca is dynamic or not, or is that hard to figure out from here?

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:16379
@@ +16378,3 @@
+      unsigned AlignedAlloc = SizeC->getZExtValue() + RegInfo->getSlotSize();
+      // Round the dynamic alloca's size up to it's alignment.
+      if (Align)
----------------
s/it's/its/


http://reviews.llvm.org/D17679