[PATCH] D16201: [ELF/AArch64] - Implemented set of R_AARCH64_TLSDESC_* relocations.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 29 08:04:30 PST 2016


grimar added inline comments.

================
Comment at: ELF/InputSection.cpp:208
@@ -207,1 +207,3 @@
 
+    // TLS descriptor lazy relocations are specific. They
+    // uses two words in the .got.plt. A single relocation is to be used to
----------------
ruiu wrote:
> Do you mean special by specific?
Probably yes. Fixed.

================
Comment at: ELF/InputSection.cpp:212-213
@@ +211,4 @@
+    // Overall design can be found in
+    // "Thread-Local Storage Descriptors for IA32 and AMD64/EM64T"
+    // http://www.fsfla.org/~lxoliva/writeups/TLS/RFC-TLSDESC-x86.txt
+    if (Target->isTlsDescRel(Type, *Body)) {
----------------
ruiu wrote:
> What is not clear in the TLS documents and in LLD's code is what is the ABI requirement and what's an optimization. We probably need to write our own document (read "long comments") to describe the TLS ABI.
I am not sure here. There is long comment about how TlsDesc works in Writer.cpp.
If we are talk about optimizations then I removed the aarch64-tls-desc-gdle.s test from this patch, because optimizations for these relocs were commited separately in r260677. And this patch does not contain any mention of optimizations anymore anywhere.


http://reviews.llvm.org/D16201





More information about the llvm-commits mailing list