[PATCH] D17486: Optionally demote fatal errors to non-fatal errors.

Manuel Klimek via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 29 01:51:26 PST 2016


klimek added inline comments.

================
Comment at: lib/Basic/DiagnosticIDs.cpp:465
@@ -464,1 +464,3 @@
 
+  // If explicitly requested, map fatal errors to errors
+  if (Result == diag::Severity::Fatal) {
----------------
Add '.'.

================
Comment at: unittests/Basic/DiagnosticTest.cpp:56
@@ +55,3 @@
+
+  {
+    // Diag that would set UncompilableErrorOccurred and ErrorOccurred.
----------------
That block seems superfluous?


http://reviews.llvm.org/D17486





More information about the llvm-commits mailing list