[PATCH] D17630: [x86, SSE] fold 'isPositive' vector integer operations (PR26701)

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 26 07:39:46 PST 2016

spatel added inline comments.

Comment at: lib/Target/X86/X86ISelLowering.cpp:26802
@@ +26801,3 @@
+  // TODO: AVX2 can handle 256-bit integer vectors.
+  if (!VT.is128BitVector() || !Subtarget.hasSSE2())
+    return SDValue();
ab wrote:
> Could this miss something crazy like v128i1, or v1i128?
Nice catch. Yes, that will fail horribly for an unsupported type. I'll enumerate the types that we can handle instead. I'll also add a comment about why we do this before type legalization: the pattern is obscured by bitcasts and other stuff after legalization.


More information about the llvm-commits mailing list