[LNT] r261851 - [test-suite] Add the ability to pass CMake defines to CMake.
James Molloy via llvm-commits
llvm-commits at lists.llvm.org
Fri Feb 26 01:02:24 PST 2016
> On 25 Feb 2016, at 21:22, Matthias Braun <mbraun at apple.com> wrote:
>> On Feb 25, 2016, at 2:05 AM, James Molloy via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> Author: jamesm
>> Date: Thu Feb 25 04:05:00 2016
>> New Revision: 261851
>> URL: http://llvm.org/viewvc/llvm-project?rev=261851&view=rev
>> [test-suite] Add the ability to pass CMake defines to CMake.
>> While we're here, ensure that we build 'timeit-host' first before anything else. CMake doesn't know that timeit-host is a requirement for building *any other source file*. This kinda works when building at the top level, but when using --only-test things break.
> At least in the generated ninja files I see a proper dependency to timeit-host and just testing to build a single benchmark when building with make/ninja from a clean state first create timeit-host and then built the benchmark, any idea why this isn't working for you?
> - Matthias
I’ve just checked, and you’re completely right - I checked all configurations and there is indeed an order dependency in the Makefile/build.ninja on each source file. I don’t know if my local testing was with some broken version of CMake, but I’ll revert this commit and debug the problem directly if it shows up again. I applied this band-aid because I didn’t think CMake was clever enough to put a dependency on the *source* files - I assumed the dependency was just at the link stage.
More information about the llvm-commits