[PATCH] D17475: MachineCopyPropagation: Catch copies of the form A<-B; A<-B

Quentin Colombet via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 19:01:18 PST 2016

qcolombet accepted this revision.
qcolombet added a comment.
This revision is now accepted and ready to land.

LGTM plus maybe a test for reserved registers (i.e., don’t do anything for those).


Comment at: test/CodeGen/AMDGPU/llvm.amdgcn.rsq.clamp.ll:34
@@ -33,4 +33,3 @@
 ; VI: s_mov_b32 s[[HIGH2:[0-9+]]], 0xffefffff
-; VI: s_mov_b32 s[[LOW2:[0-9+]]], s[[ALLBITS]]
-; VI: v_max_f64 v[0:1], v[0:1], s{{\[}}[[LOW2]]:[[HIGH2]]]
+; VI: v_max_f64 v[0:1], v[0:1], s{{\[}}[[LOW]]:[[HIGH2]]]
 define void @rsq_clamp_f64(double addrspace(1)* %out, double %src) #0 {
I guess this is the rebase messing around.

Comment at: test/CodeGen/X86/machine-copy-prop.mir:184
@@ +183,2 @@
+    NOOP implicit %rax, implicit %rbp
Could you add a test with Reserved register for both cases source and destination?



More information about the llvm-commits mailing list