[PATCH] D17587: [FileCheck] Abort if -NOT is combined with another suffix

Paul Robinson via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 12:47:47 PST 2016

probinson added a comment.

In http://reviews.llvm.org/D17587#362099, @jroelofs wrote:

> @probinson: if you're on a general crusade against more such test-writer mistakes, here's another one:
> - CHECK lines without the requisite colon
>   I've fixed a few individual instances of this before, but when I sat down to try to get FileCheck to warn about it, I couldn't see how to do it without making a mess. Perhaps you've got a better handle on how to do it?

I was not necessarily on a general campaign (although clearly FileCheck and its documentation could use a little love).  Your suggestion in particular could be subject to false positives (for example if you said "RUN: ... -check-prefix MYSTUFF" you don't want to report that RUN line).

Another one I've tripped over is that if you specify multiple -check-prefix options, FileCheck won't detect typos.  It insists that any specified combination of prefixes must result in a nonzero number of checks, but it doesn't verify that each individual prefix occurs at least once.


More information about the llvm-commits mailing list