[PATCH] D17580: Extract the method to begin and end a fragment in AsmPrinterHandler in their own method. NFC

[Amaury SECHET via llvm-commits]

deadalnix added inline comments.

================
Comment at: lib/CodeGen/AsmPrinter/DwarfCFIException.cpp:136
@@ +135,3 @@
+
+/// endFunction - Gather and emit post-function exception information.
+///
----------------
davidxl wrote:
> unnecessary code movement -- move endFunction down after endFragment
I did not move this. It always was just after beginFunction. I can reorder to keep this out of the diff.

================
Comment at: lib/CodeGen/AsmPrinter/DwarfCFIException.cpp:158
@@ +157,3 @@
+  auto *P = dyn_cast<Function>(F->getPersonalityFn()->stripPointerCasts());
+  assert(P && "Expected personality function");
+
----------------
davidxl wrote:
> Move this assertion up and make it assert (F->hasPersonalityFn() && "Expect ... ");
P is used down the road, so I'm not sure this makes sense.

================
Comment at: lib/CodeGen/AsmPrinter/DwarfException.h:67
@@ +66,3 @@
+
+  void beginFragment(const MachineBasicBlock *MBB,
+                     ExceptionSymbolProvider ESP) override;
----------------
davidxl wrote:
> Should this and the end function be declared in DwarfCFIExceptionBase? Note that there are two overrider classes to the Base class.
There are defined as doing nothing in AsmPrinterHandler, so we are good here.


http://reviews.llvm.org/D17580