[PATCH] D15390: [ThinLTO] Launch importing backends in parallel threads from gold plugin

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 07:41:17 PST 2016


tejohnson updated this revision to Diff 49061.
tejohnson added a comment.

Modify the patch to implement what is hopefully a compromise solution on
split code gen. I modified lib/CodeGen/ParallelCG.cpp to use a
ThreadPool, and go back to invoking it from the gold plugin.

This has a few nice effects:

- ThreadPool used by all ParallelCG consumers.
- Restores the pipelining of splitting and codegen (although note that with a tweak to the old version of this thread that this could be attained in the gold-plugin implementation as well).
- Avoids the recursive construction of the CodeGen object on the split code gen path.

Can one of you take a look and see if this is acceptable, and if so and
there are not other comments, mark it accepted?


http://reviews.llvm.org/D15390

Files:
  include/llvm/Support/thread.h
  lib/CodeGen/ParallelCG.cpp
  test/tools/gold/X86/pr19901_thinlto.ll
  test/tools/gold/X86/thinlto.ll
  tools/gold/gold-plugin.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D15390.49061.patch
Type: text/x-patch
Size: 32707 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160225/d559d6cb/attachment.bin>


More information about the llvm-commits mailing list