[PATCH] D17555: [Feedback requested] Implement cold spliting

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 25 06:27:54 PST 2016

rafael added a subscriber: rafael.

Comment at: lib/CodeGen/AsmPrinter/AsmPrinter.cpp:901
@@ +900,3 @@
+        OutStreamer->EmitLabel(ColdFnSym);
+        CurrentFnColdBegin = createTempSymbol("func_cold_begin");
+        OutStreamer->EmitLabel(CurrentFnColdBegin);
At least on ELF you should not need both symbols. I would suggest just passing the function name to createTempSymbol.

Even on MachO you should be able to use a single linkerPrivate symbol, no?


More information about the llvm-commits mailing list