[PATCH] D17485: [x86, InstCombine] transform x86 AVX masked stores to LLVM intrinsics

Elena Demikhovsky via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 23:26:02 PST 2016

delena added inline comments.

Comment at: lib/Transforms/InstCombine/InstCombineCalls.cpp:854
@@ +853,3 @@
+  // the LLVM intrinsic definition for the pointer argument.
+  Type *VecPtrTy = PointerType::getUnqual(Vec->getType());
+  Value *PtrCast = IC.Builder->CreateBitCast(Ptr, VecPtrTy, "castvec");
I think you lost address space here.
I know that address space is not handled properly in masked operations and there is an open discussion in LLVM-dev right now.
I think it will be resolved sooner or later. I suggest to keep the original address space anyway.


More information about the llvm-commits mailing list