[PATCH] D17324: Add a test case in LLVM to ensure covmap section is not created allocatable
David Li via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 24 19:45:55 PST 2016
davidxl added inline comments.
Comment at: test/Instrumentation/InstrProfiling/X86/alloc.ll:3
@@ +2,3 @@
+; RUN: llc < %s -mtriple=x86_64-unknown-linux-gnu | FileCheck %s
+ at __profn_foo = private constant [3 x i8] c"foo"
> vsk wrote:
> > Is the following a sufficient test?
> > ```
> > @a = internal constant i32 0, section "__llvm_covmap"
> > ; CHECK: .section __llvm_covmap,""
> > ```
> Instead of adding a new file, would it be possible to check the assembly output of `test/profile/Linux/coverage_test.cpp`?
yes the simplified version would be sufficient -- it is also more preferred than compiler-rt test as you suggested in later comment.
More information about the llvm-commits