[PATCH] D17542: Disallow generating vzeroupper before return instruction (iret) in interrupt handler function

David Kreitzer via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 14:13:13 PST 2016


DavidKreitzer added a comment.

Just one minor suggestion, Amjad. Otherwise, LGTM.


================
Comment at: test/CodeGen/X86/x86-interrupt_vzeroupper.ll:7
@@ +6,3 @@
+;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
+;; Command line: -Wall -march=nehalem -S -o - -emit-llvm -O2
+;; Source:
----------------
This command line comment seems incorrect, since nehalem doesn't have feature AVX. Maybe you should change this to sandybridge (here and on lines 35-36)?



http://reviews.llvm.org/D17542





More information about the llvm-commits mailing list