[PATCH] D17212: [ThinLTO] Support for call graph in per-module and combined summary.

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 13:49:04 PST 2016

tejohnson added a comment.

In http://reviews.llvm.org/D17212#360841, @tejohnson wrote:

> In http://reviews.llvm.org/D17212#360805, @joker.eph wrote:
> > I have a concerned about the "Only inter-module calls are recorded" part. This prevents to perform accurate pure summary-based importing decision (that I'm planning on doing).
> >  Have you measured the impact of representing the full call-graph in the summary?
> Good point, I forgot that would be needed if we want to make summary-only importing decisions. Let me add the intra-module edges and measure the added overhead.

For 483.xalancbmk, adding in the intra-module calls adds ~4% to the combined index size (so 26-27% over no callgraph) with and without PGO. This seems reasonable. Will update the patch to include those.


More information about the llvm-commits mailing list