[PATCH] D17554: MachineInstr: Respect register aliases in clearRegiserKills()

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 12:19:27 PST 2016


mcrosier added inline comments.

================
Comment at: llvm/trunk/lib/CodeGen/MachineInstr.cpp:1970
@@ -1969,3 +1969,3 @@
     unsigned OpReg = MO.getReg();
-    if (OpReg == Reg || (RegInfo && RegInfo->isSuperRegister(Reg, OpReg)))
+    if ((RegInfo && RegInfo->regsOverlap(Reg, OpReg)) || Reg == OpReg)
       MO.setIsKill(false);
----------------
As a compile-time optimization, would it make sense to perform the Reg == OpReg check before making the call to regsOverlap?


Repository:
  rL LLVM

http://reviews.llvm.org/D17554





More information about the llvm-commits mailing list