[compiler-rt] r261658 - tsan: fix signal handling in ignored libraries

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 24 04:13:47 PST 2016


On 23 February 2016 at 17:16, Dmitry Vyukov via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: dvyukov
> Date: Tue Feb 23 11:16:26 2016
> New Revision: 261658
>
> URL: http://llvm.org/viewvc/llvm-project?rev=261658&view=rev
> Log:
> tsan: fix signal handling in ignored libraries
>
> The first issue is that we longjmp from ScopedInterceptor scope
> when called from an ignored lib. This leaves thr->in_ignored_lib set.
> This, in turn, disables handling of sigaction. This, in turn,
> corrupts tsan state since signals delivered asynchronously.
> Another issue is that we can ignore synchronization in asignal
> handler, if the signal is delivered into an IgnoreSync region.
> Since signals are generally asynchronous, they should ignore
> memory access/synchronization/interceptor ignores.
> This could lead to false positives in signal handlers.

Hi Dmitry,

This failed our bot:

http://lab.llvm.org:8011/builders/clang-cmake-aarch64-full/builds/1468

ignore_lib4.cc:42:11: error: expected string not found in input
// CHECK: DONE

cheers,
--renato


More information about the llvm-commits mailing list