[PATCH] D17555: [Feedback requested] Implement cold spliting

David Li via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 23:21:35 PST 2016

davidxl added inline comments.

Comment at: lib/CodeGen/AsmPrinter/DwarfCFIException.cpp:147
@@ -147,3 +146,3 @@
-  // Provide LSDA information.
-  if (!shouldEmitLSDA)
+void DwarfCFIException::beginFragment(const MachineBasicBlock *MBB,
+                                      ExceptionSymbolProvider ESP) {
deadalnix wrote:
> davidxl wrote:
> > Another candidate of NFC refactoring.
> No, this need to be extracted as this is now needed twice: one for the regular fragment and once for the cold fragment.
that is what I am suggesting -- this part can be extracted into a helper function in another patch without changing functionality.  This patch can then use it for cold fragment as well.


More information about the llvm-commits mailing list