[PATCH] D17347: Use LLVM_LIBRARY_VISIBILITY to prevent LLVM dynamic libraries from export symbols for SROA internals.

Owen Anderson via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 16:31:34 PST 2016


> On Feb 23, 2016, at 3:19 PM, Justin Bogner <mail at justinbogner.com> wrote:
> 
> This, on the other hand, seems like a fair bit of boilerplate for not
> much gain. These are private methods and are used by run(), so hiding
> them won't really help us dead strip more or anything like that, and I
> don't really see why passes should be special compared to other LLVM
> classes in this regard.
> 
> The way I see it, if it's worth hiding the private members here, why
> wouldn't we do something to generally hide private members in most or
> all of LLVM?

I would very much like to hide them everywhere in LLVM.

—Owen
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160223/0d142db7/attachment.html>


More information about the llvm-commits mailing list