[PATCH] D17523: llvm-readobj: enable GNU output style sections and relocations printing for ELF files

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 15:43:51 PST 2016

echristo added inline comments.

Comment at: tools/llvm-readobj/ELFDumper.cpp:523
@@ -459,3 +522,3 @@
                                             const Elf_Sym *symb,
-                                            bool &IsDefault) {
+                                            bool &IsDefault) const {
   // This is a dynamic symbol. Look in the GNU symbol version table.
khemant wrote:
> echristo wrote:
> > Can you do this separately?
> This change was needed due to series of const functions that compiler figured out when I make the pointer to ELFDumper in the DumpStyle class a const pointer.
> ELFDumper.cpp:521:11: note:   no known conversion for implicit 'this' parameter from 'const {anonymous}::ELFDumper<llvm::object::ELFType<(llvm::support::endianness)0u, true> >* const' to '{anonymous}::ELFDumper<llvm::object::ELFType<(llvm::support::endianness)0u, true> >*'
Sure, it just seems like that part of the change could be separable. Including the pointer? If not, that's fine too.



More information about the llvm-commits mailing list