[PATCH] D17290: [ELF] - Teach input section wildcard patterns to recognize '?' meta character.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 14:02:47 PST 2016

ruiu accepted this revision.
ruiu added a comment.


Comment at: ELF/LinkerScript.cpp:70
@@ +69,3 @@
+// Returns true if S matches T. S can contain glob meta-characters.
+// The asterisk ('*') matches one or more characacters, and the question
+// mark ('?') matches one character.
rafael wrote:
> '*' can't really mach 0 characters?
That's a good question, and I found that either the code or this comment is wrong. If my understanding is correct, '*' in this function matches zero-or-more. We need to fix either one.


More information about the llvm-commits mailing list