[PATCH] D14382: [ELF2] - Basic implementation of -r/--relocatable

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 13:38:06 PST 2016

ruiu added inline comments.

Comment at: ELF/InputSection.h:39
@@ -38,3 +38,3 @@
-  enum Kind { Regular, EHFrame, Merge, MipsReginfo };
+  enum Kind { Regular, RelInputSection, EHFrame, Merge, MipsReginfo };
   Kind SectionKind;
So you just added RelInputSection kind? Adding a new kind and does not add a new class does not make sense. What I suggested was to actually define a new class for a relocation section. See http://reviews.llvm.org/D17551. I applied your patch and updated yours to separate the class from InputSection.


More information about the llvm-commits mailing list