[PATCH] D17341: LegalizeDAG: Use correct ptr type when expanding unaligned load/store

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 11:22:14 PST 2016


arsenm added a comment.

In http://reviews.llvm.org/D17341#354906, @ab wrote:

> If I understand correctly, ExpandUnalignedStore was correct and the changes are NFC, but ExpandUnalignedLoad wasn't, right?
>
> If so, LGTM.
>
> Otherwise I'm not sure I understand why TLI.getPointerTy(DL, AS) isn't sufficient.


No, both have the same problem.

I think it's cleaner to get the existing type rather than re-figuring it out from the address space.


http://reviews.llvm.org/D17341





More information about the llvm-commits mailing list