[PATCH] D17536: [WinEH] Don't inline an 'unwinds to caller' cleanupret into funclets which locally unwind

Joseph Tremoulet via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 23 07:38:04 PST 2016


JosephTremoulet added a comment.

`HandleInlinedEHPad` builds up the `FuncletUnwindMap` looking at the pre-inlining callee IR.  Sharing it with the new call to `getUnwindDestToken` might be benign, but I'm not sure.  I think it would be safer to use a separate `FuncletUnwindMap` for the new call.  Probably also safer to compute the unwind dest in the caller before the code on line 1759 has had a chance to give the caller EH pad new uses in the partially-rewritten inlinee which might confuse the computation.


http://reviews.llvm.org/D17536





More information about the llvm-commits mailing list