[PATCH] D17525: [WebAssembly] Implement red zone for user stack
Dan Gohman via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 23 06:49:39 PST 2016
sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.
LGTM. Please add brief description comments for needsSP and needsSPWriteback.
What the size should be is a good question. I think it makes sense to leave it at 128 for now -- big enough to be useful, but not so big that we won't get some test coverage of the non-redzone case in this early phase of development. A TODO comment or so to remind us to go back and revisit this would be good. Perhaps we should start a convention of an "ABI" comment, for things we should re-evaluate before declaring a stable ABI.
More information about the llvm-commits