[PATCH] D17502: [ELF] - Fix of 22906, referencing __start or __stop should keep the section from GC.

[Ed Schouten via llvm-commits]

ed added a comment.

In http://reviews.llvm.org/D17502#359151, @ruiu wrote:

> Although I understand the point of this patch, is this significant? Do you need this to link some specific program?


Yes. The unit testing binary for CloudABI's C library: https://github.com/NuxiNL/cloudlibc.

Each of the individual unit tests place a structure in a separate section, so they are registered automatically. The unit testing binary's entry point then iterates over all of the structures placed in this section and invokes the callbacks. Relevant sources:

https://github.com/NuxiNL/cloudlibc/blob/master/src/include/testing.h#L74-L101
https://github.com/NuxiNL/cloudlibc/blob/master/src/libc/testing/testing_execute.c#L28-L30

CloudABI recently switched over to LLD on x86-64. The only regression we run in to compared to GNU ld is this specific issue.


http://reviews.llvm.org/D17502