[PATCH] D16201: [ELF/AArch64] - Implemented set of R_AARCH64_TLSDESC_* relocations.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 15:05:47 PST 2016

ruiu added inline comments.

Comment at: ELF/InputSection.cpp:208
@@ -207,1 +207,3 @@
+    // TLS descriptor lazy relocations are specific. They
+    // uses two words in the .got.plt. A single relocation is to be used to
Do you mean special by specific?

Comment at: ELF/InputSection.cpp:212-213
@@ +211,4 @@
+    // Overall design can be found in
+    // "Thread-Local Storage Descriptors for IA32 and AMD64/EM64T"
+    // http://www.fsfla.org/~lxoliva/writeups/TLS/RFC-TLSDESC-x86.txt
+    if (Target->isTlsDescRel(Type, *Body)) {
What is not clear in the TLS documents and in LLD's code is what is the ABI requirement and what's an optimization. We probably need to write our own document (read "long comments") to describe the TLS ABI.


More information about the llvm-commits mailing list