[PATCH] D17290: [ELF] - Teach input section wildcard patterns to recognize '?' meta character.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 14:37:57 PST 2016

ruiu added inline comments.

Comment at: ELF/LinkerScript.cpp:58
@@ -57,3 +57,3 @@
-// Returns true if S matches T. S may contain a meta character '*'
-// which matches zero or more occurrences of any character.
+// Returns true if S matches T. S can contain DOS-style wildcard characters.
+// The asterisk ('*') matches one or more characacters, and the question
rafael wrote:
> grimar wrote:
> > rafael wrote:
> > > glob is probably a better known term than DOS-style wildcard.
> > https://sourceware.org/binutils/docs/ld/Input-Section-Wildcards.html
> > In specs it just called "the wildcard patterns characters" I think.
> > At least there is a mention that "The wildcard patterns are like those used by the Unix shell." and below each special symbol named as character.
> "those used by the Unix shell" == glob.
> Please don't use DOS-style.
`glob` sounds fine.


More information about the llvm-commits mailing list