[llvm] r261430 - When MemoryDependenceAnalysis hits a CFG with many transparent blocks,
Joerg Sonnenberger via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 22 11:35:17 PST 2016
On Mon, Feb 22, 2016 at 10:41:10AM -0800, Philip Reames wrote:
> Quoting from my comment on the bug several days before this landed:
> "Hm, given the investigation you've done, I am okay letting this land in
> ToT. I still don't *like* it, but you've done the work to show there's no
> better option with the current algorithm. However, I'm really not sure this
> should go into 3.8. We're fairly late in the release cycle and this change
> could have unexpected interactions. (Less optimization before other passes
> run, poor performance on key benchmarks, etc..)"
> You have not responded to these concerns. I do not believe this should be
> merged into 3.8.
I agree that it is too late for 3.8.0, but I don't think it is a problem
for a post-branch merge as requested. The committed version is less
aggressive with the limit to further reduce the potential impact.
More information about the llvm-commits