[llvm] r261547 - Revert "[ifcnv] Add comment explaining why it's OK to duplicate convergent MIs in ifcnv."

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 10:17:29 PST 2016


Author: jlebar
Date: Mon Feb 22 12:17:27 2016
New Revision: 261547

URL: http://llvm.org/viewvc/llvm-project?rev=261547&view=rev
Log:
Revert "[ifcnv] Add comment explaining why it's OK to duplicate convergent MIs in ifcnv."

This reverts r261543.  Accidental commit (not LGTM'ed).

Modified:
    llvm/trunk/lib/CodeGen/IfConversion.cpp

Modified: llvm/trunk/lib/CodeGen/IfConversion.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/IfConversion.cpp?rev=261547&r1=261546&r2=261547&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/IfConversion.cpp (original)
+++ llvm/trunk/lib/CodeGen/IfConversion.cpp Mon Feb 22 12:17:27 2016
@@ -7,8 +7,7 @@
 //
 //===----------------------------------------------------------------------===//
 //
-// This file implements the machine instruction level if-conversion pass, which
-// tries to convert conditional branches into predicated instructions.
+// This file implements the machine instruction level if-conversion pass.
 //
 //===----------------------------------------------------------------------===//
 
@@ -674,9 +673,6 @@ void IfConverter::ScanInstructions(BBInf
     if (I->isDebugValue())
       continue;
 
-    // Don't need to check isConvergent(). It's OK to duplicate convergent
-    // instructions here, because we'll only push convergent operations up the
-    // CFG -- this can only *remove* control-flow dependencies.
     if (I->isNotDuplicable())
       BBI.CannotBeCopied = true;
 




More information about the llvm-commits mailing list