[PATCH] D17499: [ELF] - replaced std::function with raw pointers in LinkerScript.cpp

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 10:13:55 PST 2016


dblaikie added inline comments.

================
Comment at: ELF/LinkerScript.cpp:120
@@ -129,2 +119,3 @@
   std::vector<StringRef> Tokens;
-  llvm::StringMap<std::function<void(ScriptParser &)>> Cmd;
+  llvm::StringMap<CmdHandler> Cmd{
+      {"ENTRY", &ScriptParser::readEntry},
----------------
Should this be static/const, then? (doesn't seem it ever gets modified, etc)


http://reviews.llvm.org/D17499





More information about the llvm-commits mailing list