[PATCH] D16173: [ThinLTO] Do not mark linkonce symbols as preempted in ThinLTO backends

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 08:50:07 PST 2016

tejohnson added a comment.

In http://reviews.llvm.org/D16173#353811, @rafael wrote:

> Is there any change the file that got the prevailing def could have the linkage changed to weak_odr? That way we would know it would output the symbol, using the same logic that is used in the regular lto case.

Yes, it seems like we could change the handling of LDPR_PREVAILING_DEF_IRONLY (and LDPR_PREVAILING_DEF_IRONLY_EXP I think) to be the same as LDPR_PREVAILING_DEF in the below switch statement. that would change linkonce_any/odr to weak_any/odr and keep the symbol. Let me try that and will update this patch.


More information about the llvm-commits mailing list