[PATCH] D17502: [ELF] - Fix of 22906, referencing __start or __stop should keep the section from GC.

Ed Maste via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 05:18:49 PST 2016

emaste added inline comments.

Comment at: ELF/MarkLive.cpp:83
@@ +82,3 @@
+static bool isRetained(SymbolTable<ELFT> *Symtab, InputSectionBase<ELFT> *Sec) {
+  StringRef Name = Sec->getOutputSectionName();
+  if (!isValidCIdentifier(Name))
Is the input->output section name mapping necessary? Those section names are not valid C identifiers anyhow.


More information about the llvm-commits mailing list