[lld] r261317 - [ELF] - Minor refactor of LinkerScript file

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 22 02:10:11 PST 2016


> Looks like these are all just function pointers (including the last one, actually) - would be more efficient, probably, to use a map to function pointer, instead of std::function, to > avoid all the extra std::function overhead?
>
> (also, you might be able to initialize this with something like: Cmd({{"Entry", &ScriptParser::readEntry}, {"EXTERN", ...}, ...}) in the init list, which might be a little more terse)

Hi David,

http://reviews.llvm.org/D17499? implements your suggestion.

George.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160222/6cbdc857/attachment.html>


More information about the llvm-commits mailing list