[llvm] r261507 - Document assumption in X86FrameLowering::inlineStackProbe()

Duncan P. N. Exon Smith via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 21 18:32:35 PST 2016


Author: dexonsmith
Date: Sun Feb 21 20:32:35 2016
New Revision: 261507

URL: http://llvm.org/viewvc/llvm-project?rev=261507&view=rev
Log:
Document assumption in X86FrameLowering::inlineStackProbe()

Resolve FIXME from r261504.  Apparently bundled instructions are illegal
here:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20160215/334146.html

Modified:
    llvm/trunk/lib/Target/X86/X86FrameLowering.cpp

Modified: llvm/trunk/lib/Target/X86/X86FrameLowering.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FrameLowering.cpp?rev=261507&r1=261506&r2=261507&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/X86FrameLowering.cpp (original)
+++ llvm/trunk/lib/Target/X86/X86FrameLowering.cpp Sun Feb 21 20:32:35 2016
@@ -462,7 +462,8 @@ void X86FrameLowering::inlineStackProbe(
   }
 
   if (ChkStkStub != nullptr) {
-    // FIXME: MBBI is a bundle iterator.  Should this be getBundleIterator()?
+    assert(!ChkStkStub->isBundled() &&
+           "Not expecting bundled instructions here");
     MachineBasicBlock::iterator MBBI =
         std::next(ChkStkStub->getInstrIterator());
     assert(std::prev(MBBI).operator==(ChkStkStub) &&




More information about the llvm-commits mailing list